[Bug 442269] Review Request: lxappearance - Feature-rich GTK+ theme switcher for LXDE

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: lxappearance - Feature-rich GTK+ theme switcher for LXDE


https://bugzilla.redhat.com/show_bug.cgi?id=442269


fedora at deadbabylon.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From fedora at deadbabylon.de  2008-04-16 03:58 EST -------
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the 
format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one 
supported architecture.
     Tested on: i386
 [x] Rpmlint output: none
 [x] Package is not relocatable.
 [x] Buildroot is correct 
(%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n))
 [x] Package is licensed with an open-source compatible license and meets 
other legal requirements as defined in the legal section of Packaging 
Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL (no version specified)
     License tag: GPLv2+
 [x] If (and only if) the source package includes the text of the license(s) 
in its own file, then that file, containing the text of the license(s) for the 
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as 
provided in the spec URL.
     MD5SUM this package    : f2214617af03a8b8fa577dcb068426b6
     MD5SUM upstream package: f2214617af03a8b8fa577dcb068426b6
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that 
are listed in the exceptions section of Packaging Guidelines.
 [x] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot} (or 
$RPM_BUILD_ROOT).
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [x] Package contains a properly installed %{name}.desktop file if it is a GUI 
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains 
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build 
http://koji.fedoraproject.org/koji/taskinfo?taskID=566855
 [x] Package should compile and build into binary rpms on all supported 
architectures.
     Tested on: koji scratch build 
http://koji.fedoraproject.org/koji/taskinfo?taskID=566855
 [x] Package functions as described.
 [x] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files are correct.
 [-] File based requires are sane.


=== Issues ===
1. The tab "available window themes" was a bit confusing because I've assumed 
that it changes the window manager theme (openbox, metacity). But it was meant 
to change the GTK2 theme _inside_ the window. This is maybe worth to be bugged 
upstream.

=== Final Notes ===
1. none


================
*** APPROVED ***
================

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.