[Bug 442522] Review Request: audit-viewer - Audit event viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: audit-viewer - Audit event viewer


https://bugzilla.redhat.com/show_bug.cgi?id=442522





------- Additional Comments From lkundrak at redhat.com  2008-04-18 09:39 EST -------
(In reply to comment #4)
> (In reply to comment #1)
> > 1.) Release: 1
> > Please include the dist tag
> The linked document states the dist tag is optional.  Is it really necessary?

Common practice is to include it for packages that contains code that is linked
to other packages in the distribution. It is usually ommited in content-only
packages, such as clip art gallery or firmware packages.

Moreover, it simplifies updating the branches with bugfixes, see the paragraph
below.

Given the guidelines do not require the dist tag, this won't block the package
approval. But I encourage you to reconsider its use.

> > 2.) You use update-desktop-database and update-mime-database
> > 
> > Please depend on required packages:
> > Requires(post): desktop-file-utils
> > Requires(postun): desktop-file-utils
> http://fedoraproject.org/wiki/Packaging/ScriptletSnippets recommends not to
> depend on these packages - to allow installing the package in non-GNOME
> environments without dragging these packages in.

Oh, sorry. Ignore that then.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.