[Bug 434973] Review Request: scidavis

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: scidavis


https://bugzilla.redhat.com/show_bug.cgi?id=434973





------- Additional Comments From lkundrak at redhat.com  2008-04-19 13:54 EST -------
Okay, rest of the review. I am horribly sorry for the delay:

1.) Desktop file

$ desktop-file-validate /home/lkundrak/rpmbuild/SOURCES/scidavis.desktop
/home/lkundrak/rpmbuild/SOURCES/scidavis.desktop: warning: key "Encoding" in
group "Desktop Entry" is deprecated
/home/lkundrak/rpmbuild/SOURCES/scidavis.desktop: warning: boolean key
"Terminal" in group "Desktop Entry" has value "0", which is deprecated: boolean
values should be "false" or "true"
/home/lkundrak/rpmbuild/SOURCES/scidavis.desktop: error: value
"application/x-scidavis" for string list key "MimeType" in group "Desktop Entry"
does not have a semicolon (';') as trailing character
$ 

* Desktop file: the Categories tag should not contain X-Fedora any more
  (wiki: Packaging/Guidelines#desktop)

2.) Duplicate files

warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational0.so
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational0.so.1
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational0.so.1.0
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational0.so.1.0.0
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational1.so
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational1.so.1
warning: 
File listed twice: /usr/lib64/scidavis/plugins/libfitRational1.so.1.0
warning: File listed twice: /usr/lib64/scidavis/plugins/libfitRational1.so.1.0.0
warning: 
File listed twice:
/usr/share/icons/hicolor/scalable/mimetypes/application-x-scidavis.svg

3.) SPEC file formatting

scidavis.src: W: mixed-use-of-spaces-and-tabs (spaces: line 92, tab: line 1)

4.) Just rm or %exclude .pyc and .pyo (unless they are needed)

rpmlint of scidavis:
scidavis.x86_64: W: non-conffile-in-etc /etc/scidavisrc.pyc
scidavis.x86_64: W: non-conffile-in-etc /etc/scidavisrc.pyo
scidavis.x86_64: W: non-conffile-in-etc /etc/scidavisrc.py

5.) Dependencies

* As scidavis ships icons in the hicolor directory, it should have "Requires:
hicolor-icon-theme"

Most of these are fairly trivial; 5. and 4. are probably most important.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.