[Bug 440597] Review Request: olpcsound - OLPC subset of csound 5

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: olpcsound -  OLPC subset of csound 5


https://bugzilla.redhat.com/show_bug.cgi?id=440597





------- Additional Comments From mtasaka at ioa.s.u-tokyo.ac.jp  2008-04-19 14:29 EST -------
Well, from a very quick glance:
* Please consider to use %?dist tag:
  http://fedoraproject.org/wiki/Packaging/DistTag
* License tag "LGPL" is invalid for current Fedora license policy:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines
  http://fedoraproject.org/wiki/Licensing
* "Requires: liblo libsndfile" is redundant and should be removed.
  These types of library dependency are automatically detected and
  added to rebuilt binary rpms.
* Don't specify %python_site_dir in the way you write now and
  please refer to
  http://fedoraproject.org/wiki/Packaging/Python
* Remove long Authors entry from %description. If you want this,
  write them in a file and include it as %doc.
* Fedora specific compilation flags are not honored (you can check
  what flags are used by "$rpm --eval %optflags")
* Please make it sure that all directories created when installing a
  rpm are owned by the rpm. For example,
  %{_libdir}/csound/ is not owned by any package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.