[Bug 442299] Review Request: python-gtkextra - Python bindings for gtkextra

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-gtkextra - Python bindings for gtkextra


https://bugzilla.redhat.com/show_bug.cgi?id=442299


lkundrak at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From lkundrak at redhat.com  2008-04-20 01:50 EST -------
(In reply to comment #3)

> > 3.) %configure --disable-numpy
> > 
> > Is there a reason to disable numpy? We have numpy in Fedora afaik.
> The package does not build with current numpy.  Given that the last release of
> python-gtkextra happened four years ago, I'd prefer avoiding extensive patching
> (otherwise Fedora could become something like a new upstream for the package,
> and I currently don't care about it that much).
> 
> If an user requests numpy support - or if you insist on it - I'll take a look
> and make it build (if not work), but I'd rather not.  Other features of
> python-gtkextra that don't build were dealt with in the same manner - by
> removing them.

Given there is a good reason to disable numpy support, I think it is not
required. If someone requires numpy support, he can still open a bug report.

4.) python-gtkextra-1.1.0-update.patch

What's this patch? Seems like a lot of unrelated changes -- is it a diff between
release and a CVS snapshot? Please add a comment to it.

5.) rpmlint of python-gtkextra:

python-gtkextra.x86_64: W: devel-file-in-non-devel-package
/usr/lib64/pkgconfig/python-gtkextra.pc

Apart from these two, fairly minor, issues, I see no more problems.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.