[Bug 443310] Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4
bugzilla at redhat.com
bugzilla at redhat.com
Sun Apr 20 15:21:50 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: xfwm4-theme-nodoka - Nodoka theme for xfwm4
https://bugzilla.redhat.com/show_bug.cgi?id=443310
martin.sourada at gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flag| |fedora-review?
------- Additional Comments From martin.sourada at gmail.com 2008-04-20 11:21 EST -------
Must items:
rpmlint clean
name OK
specfile OK
follow the guidelines OK
has approved license OK
md5 correct for the temporary source on your page
package builds OK
no locales OK
no shared libs OK
owns its dirs OK
Problems:
URL was not correct so I've uploaded the sources in your stead to speed up the
review. (https://fedorahosted.org/releases/n/o/nodoka/xfwm4-theme-nodoka-0.1.tar.gz)
missing rm -rf $RPM_BUILD_ROOT in %%install section
Once you fix the last issue, I'll approve it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list