[Bug 442263] Review Request: quicksynergy - GUI for easily configuring Synergy2

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: quicksynergy - GUI for easily configuring Synergy2


https://bugzilla.redhat.com/show_bug.cgi?id=442263


lkundrak at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From lkundrak at redhat.com  2008-04-20 15:42 EST -------
Thanks for the package.

1.) Desktop file needs some love:

$ desktop-file-validate /home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: key "Encoding" in
group "Desktop Entry" is deprecated
/home/lkundrak/rpmbuild/SOURCES/quicksynergy.desktop: warning: value
"Network;Application;" for key "Categories" in group "Desktop Entry" contains a
deprecated value "Application"
$ 

Icon=qslogo.png

This is invalid. You should omit the .png suffix.

Name=QuickSynergy

Hm, there is no entry key that would tell tell much about what's the application
for. How about "Mouse and Keyboard Sharing" or something similar? Check out
GenericName and Comment keys.

The same applies for "Summary:" in the spec file.

http://standards.freedesktop.org/desktop-entry-spec/latest/

2.) /usr/share/pixmaps/qslogo.png should not be executable.

-rwxr-xr-x 1 root root 3897 2008-04-20 21:34 /usr/share/pixmaps/qslogo.png
Use install -m 644 instead of install to copy it.

In other respects the package looks fine. It is legible, sane. Builds fine in
mock, uses required make and compile flags. rpmlint does not complain.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.