[Bug 443926] Review Request: pyephem - The astronomy library for Python
bugzilla at redhat.com
bugzilla at redhat.com
Thu Apr 24 20:08:50 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pyephem - The astronomy library for Python
Alias: pyephem-review
https://bugzilla.redhat.com/show_bug.cgi?id=443926
------- Additional Comments From lkundrak at redhat.com 2008-04-24 16:08 EST -------
0.) The use of env is kind of useless here.
env CFLAGS="$RPM_OPT_FLAGS" python setup.py build
env CFLAGS="$RPM_OPT_FLAGS" python setup.py install --root=$RPM_BUILD_ROOT
1.) Requires: python
This is useless as well. The dependency on python has to be versioned, as the
file names are versioned, and I believe the correct one is automatically
generated anyways.
2.) rpmlint outputs these:
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_usno.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_dates.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_usno_equinoxes.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/ephem_test.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_bodies.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_rst.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_angles.py 0644
pyephem.x86_64: E: non-executable-script
/usr/lib64/python2.5/site-packages/ephem/tests/test_constants.py 0644
Do you believe those should realy be installed? What making them executable and
utilizing the %test section then?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list