[Bug 443807] Review Request: NetworkManager-pptp - PPTP support for NetworkManager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: NetworkManager-pptp - PPTP support for NetworkManager
Alias: nm-pptp-review

https://bugzilla.redhat.com/show_bug.cgi?id=443807





------- Additional Comments From lkundrak at redhat.com  2008-04-24 17:07 EST -------
(In reply to comment #3)

Thanks for the review.

> comments:
> - mixed usage of $RPM_BUILD_ROOT and %{buildroot} in %install section

Fixed.

> - you should remove BR: autoconf automake

Fixed.

> - files in %{_sysconfdir} should be marked as %config

These are not really configuration files. At least not user-adjustable.

> - NetworkManager-pptp.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/libnm-pptp-properties.so
>     is libnm-pptp-properties a plugin or real library? plugins should have
> -avoid-version in their LDFLAGS

Right. Patched that out.

> - remove ldconfig calls from the scriptlets (depends on ^)

Done.

> - remove R(post,postun): /sbin/ldconfig - added automagically when ldconfig is
> used in scriptlets

Done.

http://people.redhat.com/lkundrak/SPECS/NetworkManager-pptp.spec
http://people.redhat.com/lkundrak/SRPMS/NetworkManager-pptp-0.6.4-2.fc8.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.