[Bug 442693] Review Request: geoclue - Geoclue is a modular geoinformation service

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: geoclue - Geoclue is a modular geoinformation service


https://bugzilla.redhat.com/show_bug.cgi?id=442693





------- Additional Comments From mclasen at redhat.com  2008-04-25 09:44 EST -------
Hey, thanks for picking this up, it was on my list of things to look at...


Some preliminary comments on the spec file:


This looks wrong, only devel packages should require devel packages:

Requires: gtk2-devel 


These will almost certainly be pulled in automatically be library dependencies,
so no need to list them explicitly:
 
Requires: glib2
Requires: libxml2
Requires: GConf2


The devel package must require pkgconfig, since it contains a pc file.


The description is misleading, since the devel package should _not_ contain
static libraries. It should contain the unversioned symlinks (.so) for shared
libraries.


Running autogen.sh should only be necessary when building from a checkout. Even
if this package is based on a git snapshot right now, the tarball should be
produced by 'make dist' and the autogen.sh call should be unnecessary. If it
were necessary for some reason, then you are missing the necessary BuildRequires
for automake, autoconf, etc


missing from the file list:
%dir %{_datadir}/geoclue-providers
%dir %{_includedir}/geoclue




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.