[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: hylafax


https://bugzilla.redhat.com/show_bug.cgi?id=188542





------- Additional Comments From faxguy at howardsilvan.com  2008-04-26 18:36 EST -------
Okay, I'm now testing with Fedora 9 Preview.  The patch for configure does work.

I sympathize with the dislike for the non-standard configure script and
Makefiles.  They can be quite cumbersome at times.  Due to other projects with
which I am involved I am familiar with autotools, and in my opinion, the score
between them really is par.  autotools, itself, can be quite cumbersome... not
only for developers, but also for users who may have to hunt down specific
versions of autotools to make things work right.  I am in no way against looking
for a better way, even if that does mean autotools, but for now it's probably
best to address the issues in the existing configure script and wait for such a
time as someone passionate about this issue comes along - or until an undeniable
advantage manifests itself in making a conversion.

1) "The test trying to check for -O -g must have failed."

Indeed.  This has now been fixed.

2) Traditionally HylaFAX configure used --with-GCOPTS= and --with-GCXXOPTS
instead of CFLAGS and CXXFLAGS.  I've now made configure use CFLAGS and CXXFLAGS
instead if GCOPTS and GCXXOPTS are not given.

3) I'm not having a problem with PAM detection:

Checking for PAM (Pluggable Authentication Module) support
... found. Enabling PAM support

I get this both with the source build (from tarball) and with rpmbuild.  Are you
sure that you have pam-devel installed?  Please check again with the SRPM that
I'll link below.

4) "Using ZLIB include files from"

This can be ignored.  I've made configure not print this message if $ZLIBINC is
empty.

5) "./configure: line 3274: 28995 Segmentation fault      $TIFFBIN/tiffcp -c g4
misc/jbig.tif misc/foo.tif > /dev/null 2>&1"

Here configure is checking to see if your libtiff supports JBIG or not, and it
doesn't, and in fact your libtiff segfaults when trying to process
JBIG-compressed TIFF files.  configure correctly interprets this, however, the
output is, indeed, annoying, and so I've made configure now silence this.

6) I'm not sure how to resolve this one.  configure takes efforts to find the
needed library headers in non-standard locations and then uses -I for them. 
Assuming it finds them in /usr/include then that's what you're seeing.  When
should -I be used or not?

7) From the spec file comments:

# FAXUSER, FAXGROUP, SYSUSER and SYSGROUP are set to the current user to
# avoid warnings about chown/chgrp if the user building the SRPM is not root;
# they are set to the correct values with the RPM attr macro

Thanks.

SPEC: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax.spec
SRPM: http://osdn.dl.sourceforge.net/sourceforge/hylafax/hylafax-5.2.4-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.