[Bug 225792] Merge Review: gfs2-utils

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: gfs2-utils


https://bugzilla.redhat.com/show_bug.cgi?id=225792


kevin at tummy.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kevin at tummy.com  2008-04-28 22:36 EST -------
Sorry for the delay here... ;( 

1-5 look good. 

6. You aren't stopping the service in preun, you might want to do that?

7. 
rpmlint now looks much better: 
gfs2-utils.x86_64: W: service-default-enabled /etc/init.d/gfs2
gfs2-utils.x86_64: E: missing-mandatory-lsb-keyword Description in /etc/init.d/gfs2
gfs2-utils.x86_64: E: missing-mandatory-lsb-keyword Short-Description in
/etc/init.d/gfs2
gfs2-utils.x86_64: W: incoherent-init-script-name gfs2

So, I don't see any further blocker issues here. You might look at item 6 again,
but otherwise things look good. This package is APPROVED. 

Feel free to close this bug RAWHIDE. 

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.