[Bug 443249] Review Request: rubygem-hoe - Hoe is a simple rake/rubygems helper for project Rakefiles
bugzilla at redhat.com
bugzilla at redhat.com
Tue Apr 29 20:56:49 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-hoe - Hoe is a simple rake/rubygems helper for project Rakefiles
https://bugzilla.redhat.com/show_bug.cgi?id=443249
tcallawa at redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody at fedoraproject.org |tcallawa at redhat.com
Flag| |fedora-review?
------- Additional Comments From tcallawa at redhat.com 2008-04-29 16:56 EST -------
Review done on -2.
Bad:
- license in SPEC does not match code
Code is under "MIT", spec says "GPLv2+ or Ruby".
Good:
- rpmlint checks return:
rubygem-hoe.src: W: mixed-use-of-spaces-and-tabs (spaces: line 37, tab: line 7)
Safe to ignore.
- package meets naming guidelines
- package meets packaging guidelines (generic and ruby)
- spec file legible, in am. english
- source matches upstream (5f147e5b098f1615d387c8c4ebe68ee740d30a8e)
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
Show me a SRPM/SPEC with the license fixed and I'll approve.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
More information about the package-review
mailing list