[Bug 457505] Package Review: perl-Wx-Perl-ProcessStream

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Package Review: perl-Wx-Perl-ProcessStream


https://bugzilla.redhat.com/show_bug.cgi?id=457505





------- Additional Comments From rnorwood at redhat.com  2008-08-01 12:47 EST -------
Review results - the starred items need to be fixed before I can pass the
package review:

- Source matches upstream
- rpmlint passes

* Missing BuildRequires: perl(Test::More)

* Error generating Makefile:
+ /usr/bin/perl Makefile.PL INSTALLDIRS=vendor
Checking if your kit is complete...
Looks good
Error: Unable to initialize gtk, is DISPLAY set properly?
Writing Makefile for Wx::Perl::ProcessStream

Is this a real error?  I suspect not, since the package still builds and works.


- Package naming is ok
- License is ok
- Source matches upstream

* Package does *not* build in koji.  See:
http://koji.fedoraproject.org/koji/taskinfo?taskID=753064

>From build.log:

"""
Error: Unable to initialize gtk, is DISPLAY set properly?
Use of uninitialized value $Wx::_universal in concatenation (.) or string at
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Wx.pm line 176.
Use of uninitialized value $Wx::_static in concatenation (.) or string at
/usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/Wx.pm line 177.
Use of uninitialized value $Wx::wxVERSION_STRING in concatenation (.) or string
at
/builddir/build/BUILD/Wx-Perl-ProcessStream-0.11/blib/lib/Wx/Perl/ProcessStream.pm
line 346.
"""

Probably the best solution is to include a patch to disable/comment out the
tests that fail.

FYI, you can do a koji scratch build easily.  Just build an SRPM with your
changes, and run:

$ koji build --skip-tag --scratch dist-f9 /path/to/SRPM

That way you can make sure you've gotten all the failing tests.

- File and directory ownership is ok



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.