[Bug 421241] Review Request: php-ZendFramework - Leading open-source PHP framework

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: php-ZendFramework - Leading open-source PHP framework


https://bugzilla.redhat.com/show_bug.cgi?id=421241


giallu at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From giallu at gmail.com  2008-08-01 19:40 EST -------
==== REVIEW CHECKLIST ====
- package named according to package naming guidelines
- spec filename matches %{name}
- package meet packaging guidelines
- package licensed with open source compatible license (BSD)
- license matches actual license
- license file included in %doc
- spec written in American english
- spec legible
- source match upstream
196aef8904be20c199e536480f92c5c9  ./ZendFramework-1.6.0RC1.tar.gz
- successfully builds in mock for rawhide x86_64
- no locales
- no shared libraries
- package is not relocatable
- package owns all directories it creates
- file permissions set properly
- contains proper %clean
- macro usage is consistent
- package contains code
- no large documentation
- not a GUI app needing a .desktop file

- rpmlint output not clean

php-ZendFramework-Cache-Backend-Apc.noarch: W: no-documentation
php-ZendFramework-Cache-Backend-Memcached.noarch: W: no-documentation
php-ZendFramework-Cache-Backend-Memcached.noarch: W:
filename-too-long-for-joliet
php-ZendFramework-Cache-Backend-Memcached-1.6.0-0.1.rc1.fc9.noarch.rpm
php-ZendFramework-demos.noarch: W: no-documentation
php-ZendFramework-demos.noarch: E: htaccess-file
/usr/share/php/Zend/demos/OpenId/mvc_auth/html/.htaccess
php-ZendFramework-Feed.noarch: W: no-documentation
php-ZendFramework-Gdata.noarch: W: no-documentation
php-ZendFramework-Pdf.noarch: W: no-documentation
php-ZendFramework-Search-Lucene.noarch: W: no-documentation
php-ZendFramework-Services.noarch: W: no-documentation
php-ZendFramework-tests.noarch: W: no-documentation
php-ZendFramework-tests.noarch: E: zero-length
/usr/share/php/Zend/tests/Zend/Filter/_files/file.1
php-ZendFramework-tests.noarch: E: non-executable-script
/usr/share/php/Zend/tests/Zend/Text/Figlet/GenerateDummies.sh 0644
php-ZendFramework-tests.noarch: E: zero-length
/usr/share/php/Zend/tests/Zend/Text/Figlet/InvalidFont.flf
php-ZendFramework-tests.noarch: W: hidden-file-or-dir
/usr/share/php/Zend/tests/Zend/Auth/Adapter/Digest/_files/.htdigest.1
php-ZendFramework-tests.noarch: E: zero-length
/usr/share/php/Zend/tests/Zend/Soap/_files/cert_file
php-ZendFramework-tests.noarch: E: zero-length
/usr/share/php/Zend/tests/Zend/Http/Client/_files/testHeaders.php
php-ZendFramework-tests.noarch: W: file-not-in-%lang
/usr/share/php/Zend/tests/Zend/Translate/_files/test_fileerror.mo
php-ZendFramework-tests.noarch: W: file-not-in-%lang
/usr/share/php/Zend/tests/Zend/Translate/_files/testmsg_en.mo
php-ZendFramework-tests.noarch: W: file-not-in-%lang
/usr/share/php/Zend/tests/Zend/Translate/_files/testmsg_ru(koi8-r).mo
php-ZendFramework-tests.noarch: W: file-not-in-%lang
/usr/share/php/Zend/tests/Zend/Translate/_files/translate_bigendian.mo
10 packages and 0 specfiles checked; 6 errors, 15 warnings.


I think the "no-documentation" warnings could be ignored on subpackages. You may
consider adding the license file to silence it

filename-too-long-for-joliet is annoying if this is going to be burned on a
CD/DVD. I am not sure if that's a blocker

htaccess-file  IIRC htaccess files are ignored by the default apache
installation. please check if we can remove it without impacting the demo.

I think all the -tests W and E can be safely ignored. Please just double check
the .htdigest.1 and the zero lenght files are really the test targets.

One last remark. If there is some post installation steps the user is supposed
to do, please add a README.Fedora file with the appropriate note.

So, I can't see any blocker here, the package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.