[Bug 435227] Review Request: xpsk31 - GTK+ graphical version of lpsk31

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: xpsk31 - GTK+ graphical version of lpsk31


https://bugzilla.redhat.com/show_bug.cgi?id=435227


kanarip at kanarip.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|kanarip at kanarip.com         |cooly at gnome.eu.org
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From kanarip at kanarip.com  2008-08-02 05:33 EST -------
The source tarball is a 404, again, and it seems upstream has a new version 1.2
that builds with the same spec and patches

RPM Lint: OK, silent
Package name: OK
Spec file: OK
License: OK, GPLv2+
Actual License: OK, no license file but code says GPLv2+
%doc License: No, license is in the code
Spec file language: OK
Spec file readable: OK
Upstream source vs. used tarball: Upstream tarball disappears when new version
is released. Newer version 1.2 builds with the same spec and the same patches,
so no problem. Might wanna contact upstream to make them have the tarballs
around a little longer though.

Compile and Build:
- F-7: OK
- F-8: OK
- rawhide: OK
- EL-5: OK

Applicable Package Guidelines:

Locales: N/A
Shared libs: N/A

Relocatable: N/A
Directory and file ownership: OK
No duplicate files in %files: OK
File Permissions: OK
Macro usage: OK
Code vs. Content: OK
(Large) Documentation: OK
%doc affecting runtime: OK
Header files in -devel package: N/A
Static Libraries in -static package: N/A
pkgconfig Requires: N/A
Library files: N/A
Devel requires base package: N/A
.la libtool archives: N/A
Duplicate ownership of files/directories: OK
Remove BuildRoot: OK
UTF-8 filenames: OK

package approved in principle, but you might want to bump the version and
contact upstream about the disappearing tarballs.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.