[Bug 457035] Review Request: libproxy - A library handling all the details of proxy configuration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libproxy - A library handling all the details of proxy configuration


https://bugzilla.redhat.com/show_bug.cgi?id=457035


adel.gadllah at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |adel.gadllah at gmail.com
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review?




------- Additional Comments From adel.gadllah at gmail.com  2008-08-02 06:39 EST -------
Review
=============

[+]	source files match upstream:
		2b2b00a179740548035a1145bbae600db9b0a2ce
[-]	package meets naming and versioning guidelines:
		please use libproxy-python instead of libproxy-binding-python
[+]	specfile is properly named, is cleanly written and uses macros consistently.
[+]	dist tag is present.
[+]	build root is correct.
[+]	license field matches the actual license.
[+]	license is open source-compatible.

[+]	license text included in package.
[+]	latest version is being packaged.
[+]	BuildRequires are proper.
[-]	Requires are proper:
		xulrunner does not use soname's so please add 
		Requires: gecko-libs >= 1.9 to the plugin-mozjs
		package.
[+]	compiler flags are appropriate.
[+]	%clean is present.
[+]	package builds in koji:
		http://koji.fedoraproject.org/koji/taskinfo?taskID=745038
[+]	package installs properly.
[+]	debuginfo package looks complete.
[+]	rpmlint is silent:
	It isn't:
	-----------
	libproxy-binding-python.x86_64: W: no-documentation
	libproxy-devel.x86_64: W: no-documentation
	libproxy-plugin-gnome.x86_64: W: no-documentation
	libproxy-plugin-kde.x86_64: W: no-documentation
	libproxy-plugin-mozjs.x86_64: W: no-documentation
	libproxy-plugin-networkmanager.x86_64: W: no-documentation
	8 packages and 0 specfiles checked; 0 errors, 6 warnings.
	------------
	But this warnings can be ignored.

[+]	ldconfig is used in %post and %postun
[+]	owns the directories it creates.
[+]	doesn't own any directories it shouldn't.
[+]	no duplicates in %files.
[+]	file permissions are appropriate.
[+]	code, not content.
[+]	documentation is small, so no -docs subpackage is necessary.
[+]	%docs are not necessary for the proper functioning of the package.

===============

Summary & Comments:

1) Please use libproxy-python instead of libproxy-binding-python
1.1) Any reason why the java and C# bindings aren't packaged?
2) Fix the gecko-libs requires
3) Consider submitting the patch to upstream (if not done already).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.