[Bug 455555] Review Request: libhocr - A Hebrew optical character recognition library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=455555





--- Comment #7 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-03 12:25:01 EDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > ** Requires
> > *  Requires for -devel subpackage
> > ---------------------------------------------------------------
> >         This means that libhocr-devel subpackage must have "Requires: gtk2-devel"
> > 
> >      B. %_libdir/pkgconfig/libhocr.pc contains:
> > ---------------------------------------------------------------
> > Libs: -lhocr  -lhspell -lz  -ltiff -lm
> > ---------------------------------------------------------------
> >         This means that libhocr-devel must have 
> >         "Requires: hspell-devel zlib-devel libtiff-devel" (because of
> >         -lhspell -lz -ltiff)
> >         However all these 3 linkage seem unneeded, because none of the
> >         header files in libhocr-devel needs header files from 
> >         fftw-devel, hspell-devel, libtiff-devel.
> >         I guess "@ld_hspell@ @ld_tiff@" in libhocr.pc.in should be removed.
> 
> Their inclusion in the .pc file is correct since they are used
> by the applications, either explicitly (tiffio.h and fftw3.h) or
> implicitly (hspell via gtkspell). 

I guess currently I don't understand what you want to say correctly.
libhocr-devel itself does not need tiffio.h or fftw3.h.

> > * Timestamps
> >   - To keep timestamps on installed files, please consider to use
> > ----------------------------------------------------------------
> > make install \
> >         INSTALL="install -p" \
> >         DESTDIR=%{buildroot}            \
> > .....
> > -----------------------------------------------------------------
> >     This method usually works for based Makefiles based on recent
> >     autotools
> 
> Hmmm... first time I see this consideration. It seems logical
> but are these any guideline about it?

Although in PackagingDrafts, I usually recommend this:
https://fedoraproject.org/wiki/PackagingDrafts/MultilibTricks#Timestamps

> > * Desktop files
> >   - Category "X-Fedora" is deprecated and should be removed.
> 
> Done. I must have got its addition from some obsolete guide
> somewhere but I cannot find any reference to it now, nevermind.

Perhaps this is difficult to find:
http://www.redhat.com/archives/fedora-extras-list/2006-October/msg00725.html

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.