[Bug 450371] Review Request: pokegen - Strategy/RPG game engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450371





--- Comment #15 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-04 14:59:31 EDT ---
By the way aside from naming:

* SourceURL
  https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
  - If you are using svn controlled tarball, you should write in the spec
    file as comments how you created the tarball using as Source.

* Macros
  - Use macros properly. /usr should be %{_prefix}:
    https://fedoraproject.org/wiki/Packaging/RPMMacros

** Scriptlets
 * mimeinfo
   - Please follow
     https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#mimeinfo

 * desktop database
   - As pokemodr.desktop has Mimetype entry, please follow
    
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database

* Unused direct dependencies
  - rpmlint shows (note: rpmlint can be used for installed rpms)
--------------------------------------------------------------
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/usr/lib/libpokescripting.so.0
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/usr/lib/libkdeui.so.5
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/usr/lib/libQtSvg.so.4
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/usr/lib/libkdecore.so.5
pokegen.i386: W: unused-direct-shlib-dependency /usr/lib/libpokebattle.so.0.0.2
/lib/libpthread.so.0
--------------------------------------------------------------
    You can check this by
    $ ldd -u /usr/lib/libpokebattle.so

    Usually even with these unused direct dependencies left the
program/libraries
    should work. However this may bring about unneeded dependency for the rpm
    including the program/library. As you are the upstream, you may want to
    fix this issue.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.