[Bug 226363] Merge Review: redhat-lsb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226363


Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
    Customer Facing|NO                          |---




--- Comment #39 from Jens Petersen <petersen at redhat.com>  2008-08-06 01:41:06 EDT ---
There really needs to be a license file added to the top directory.

License header in longer source files would be desirable too, specially C code.

Some comments on the latest patch:

-%define srcrelease 5
+%define srcrelease 4

Please use 3.1.x for future releases

-Version: 3.1
+Version: 3.2

Is there a new upstream??

+Release: 1.f9

You must use "1%{?dist}".

-License: GPLv2
+License: GPLv2 and GPLv2+ and LGPLv2

Not sure where this came from earlier...

-BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+BuildRoot: %{_tmppath}/%{name}-root

No!

 # dependency for primary LSB application for v1.3
 Provides: lsb = %{version}
 # dependency for primary LSB application for v2.0 and v3.0
@@ -93,120 +91,290 @@ ExclusiveArch: i386 ia64 x86_64 ppc ppc6

 %ifarch %{ix86}
 # archLSB IA32 Base Libraries
-Requires: libz.so.1
-Requires: libutil.so.1
-Requires: libpthread.so.0
-Requires: libncurses.so.5
-Requires: libm.so.6
-Requires: libgcc_s.so.1
-Requires: libdl.so.2
-Requires: libcrypt.so.1
+Requires: libatk-1.0.so.0
 Requires: libc.so.6
+Requires: libcrypt.so.1
+Requires: libdl.so.2
+Requires: libgcc_s.so.1
+Requires: libgdk-x11-2.0.so.0
+Requires: libgdk_pixbuf-2.0.so.0
+Requires: libgdk_pixbuf_xlib-2.0.so.0
+Requires: libglib-2.0.so.0
+Requires: libgmodule-2.0.so.0
+Requires: libgobject-2.0.so.0
+Requires: libgthread-2.0.so.0
+Requires: libgtk-x11-2.0.so.0
+Requires: libm.so.6
+Requires: libncurses.so.5
+Requires: libpango-1.0.so.0
+Requires: libpangoft2-1.0.so.0
+Requires: libpangoxft-1.0.so.0
+Requires: libpthread.so.0
+Requires: libqt-mt.so.3
+Requires: libQtCore.so.4
+Requires: libQtGui.so.4
+Requires: libQtNetwork.so.4
+Requires: libQtOpenGL.so.4
+Requires: libQtSql.so.4
+Requires: libQtSvg.so.4
+Requires: libQtXml.so.4
 Requires: libstdc++.so.6
+Requires: libutil.so.1
+Requires: libz.so.1

Lot of changes?

-touch $RPM_BUILD_ROOT%{_sysconfdir}/lsb-release.d/core-3.1-%{archname}
-touch $RPM_BUILD_ROOT%{_sysconfdir}/lsb-release.d/core-3.1-noarch
-touch $RPM_BUILD_ROOT%{_sysconfdir}/lsb-release.d/graphics-3.1-%{archname}
-touch $RPM_BUILD_ROOT%{_sysconfdir}/lsb-release.d/graphics-3.1-noarch
+touch $RPM_BUILD_ROOT/etc/lsb-release.d/core-3.2-%{archname}
+touch $RPM_BUILD_ROOT/etc/lsb-release.d/core-3.2-noarch
+touch $RPM_BUILD_ROOT/etc/lsb-release.d/desktop-3.2-%{archname}
+touch $RPM_BUILD_ROOT/etc/lsb-release.d/desktop-3.2-noarch

Please use %{_sysconfdir}.

-  $RPM_BUILD_ROOT%{_sbindir}/redhat_lsb_trigger.%{_target_cpu}
+  $RPM_BUILD_ROOT/usr/sbin/redhat_lsb_trigger.%{_target_cpu}

Why?

+#/usr/X11R6/lib/X11/fonts
+#/usr/X11R6/lib/X11/rgb.txt

Please drop lines.

 %defattr(-,root,root)
-%doc README

Why?

-%{_sysconfdir}/redhat-lsb
-%dir %{_sysconfdir}/lsb-release.d
-%{_sysconfdir}/lsb-release.d/*
+/etc/redhat-lsb
+#%config /etc/lsb-release
+#/etc/redhat-lsb
+%dir /etc/lsb-release.d
+/etc/lsb-release.d/*

No!

+#%dir /usr/X11R6/lib/X11/xserver
+#/usr/X11R6/lib/X11/xserver/*

Again

-#/bin/mailx
+/bin/mailx

No!

-%{_sbindir}/redhat_lsb_trigger.%{_target_cpu}
+/usr/sbin/redhat_lsb_trigger.%{_target_cpu}

No

+#/usr/X11R6/lib/X11/xserver/SecurityPolicy
+#/usr/X11R6/lib/X11/fonts
+#/usr/X11R6/lib/X11/rgb.txt

Ditto

 %changelog
-* Thu Jul 31 2009 Lawrence Lim <llim at redhat.com> - 3.1-21
-- remove symlink for mailx (Bug #457241)
-
-* Tue Feb 19 2008 Fedora Release Engineering <rel-eng at fedoraproject.org> -
3.1-20
-- Autorebuild for GCC 4.3
-
-* Wed Oct 3 2007 Lawrence Lim <llim at redhat.com> - 3.1-19
-- fix build issue on ppc - (.opd+0x10): multiple definition of
`__libc_start_main'

It is not considered good to remove old changelog entries - please leave them.

+* Wed Apr 16 2008 Mats Wichmann <mats at freestandards.org> 3.2-1
+- port forward to LSB 3.2

You can put it in your name, I think.

-* Fri Sep 21 2007 Lawrence Lim <llim at redhat.com> - 3.1-18
-- fix build issue in minimal build root (Bug #265241)
-
-* Wed Aug 29 2007 Fedora Release Engineering <rel-eng at fedoraproject dot
org> - 3.1-17
-- Rebuild for selinux ppc32 issue.
-
-* Fri Aug 20 2007 Lawrence Lim <llim at redhat.com> - 3.1-16
-- update spec file in accordance to feedback provided through merge review -
merge-review.patch - #226363
-
-* Wed Jul 18 2007 Lawrence Lim <llim at redhat.com> - 3.1-15.f8
+* Wed Jul 18 2007 Lawrence <llim at redhat.com> - 3.1-13.f8
 - Resolved: #239842 - /lib/lsb/init-functions shall use aliases but not
functions
-- forward port the patch from 3.1-12.3.EL which fix #217566, #233530, #240916
-
-* Wed May 2 2007 Lawrence Lim <llim at redhat.com> - 3.1-14.fc7
-- fixed Bug 232918 for new glibc version
+- forward port the patch from 3.1-12.3.EL

-* Wed Feb 21 2007 Lawrence Lim <llim at redhat.com> - 3.1-13
-- fixed Bug 226363
+* Tue Jun 26 2007 Lawrence Lim <llim at redhat.com> - 3.1-12.3.EL
+- Resolves: #217566 - rewrite /lib/lsb/init-functions file needs to define the
commands as true shell functions rather than aliases.
+- Resolves: #233530 - LSB pidofproc misspelled as pidofprof.
+- Resolves: #240916 - "log_warning_message" replaced with "log_warning_msg"
per the LSB 3.1 spec
+
+* Wed Dec 6 2006 Lawrence Lim <llim at redhat.com> - 3.1-12.2.EL
+- Resolves: bug 217566
+- revise patch

So this is a forward port from RHEL?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.