[Bug 226363] Merge Review: redhat-lsb

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226363


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |panemade at gmail.com




--- Comment #42 from Parag AN(पराग) <panemade at gmail.com>  2008-08-06 04:05:38 EDT ---
Ok. lets start review again with new maintainer.
rpmlint on binary gave me
redhat-lsb.i386: W: dangling-relative-symlink /lib/ld-lsb.so.3 ld-linux.so.2
redhat-lsb.i386: W: dangling-relative-symlink /usr/lib/lsb/install_initd
../../../sbin/chkconfig
redhat-lsb.i386: W: dangling-relative-symlink /usr/lib/lsb/remove_initd
../../../sbin/chkconfig
==> Ok 

redhat-lsb.i386: E: zero-length /etc/lsb-release.d/core-3.1-ia32
redhat-lsb.i386: W: non-conffile-in-etc /etc/lsb-release.d/core-3.1-ia32
redhat-lsb.i386: E: zero-length /etc/lsb-release.d/graphics-3.1-noarch
redhat-lsb.i386: W: non-conffile-in-etc /etc/lsb-release.d/graphics-3.1-noarch
redhat-lsb.i386: E: zero-length /etc/lsb-release.d/graphics-3.1-ia32
redhat-lsb.i386: W: non-conffile-in-etc /etc/lsb-release.d/graphics-3.1-ia32
redhat-lsb.i386: E: zero-length /etc/lsb-release.d/core-3.1-noarch
redhat-lsb.i386: W: non-conffile-in-etc /etc/lsb-release.d/core-3.1-noarch
==> As explained in SPEC needed these LSB Profile files and as they are not
having any contents no issue of marking as conffile.

redhat-lsb.i386: E: non-readable /usr/sbin/redhat_lsb_trigger.i386 0700
redhat-lsb.i386: E: non-standard-executable-perm
/usr/sbin/redhat_lsb_trigger.i386 0700
redhat-lsb.i386: E: statically-linked-binary /usr/sbin/redhat_lsb_trigger.i386
==> Not sure about this for now

redhat-lsb.i386: E: only-non-binary-in-usr-lib
==> From LSB documentation page 460 this looks ok.

redhat-lsb.i386: W: incoherent-version-in-changelog 3.1-22 3.1-21.fc10
==> Change Release tag in SPEC

rpmlint on SRPM gave

redhat-lsb.src:361: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/lsb
redhat-lsb.src:379: E: hardcoded-library-path in
$RPM_BUILD_ROOT/usr/lib/lsb/install_initd
redhat-lsb.src:380: E: hardcoded-library-path in
$RPM_BUILD_ROOT/usr/lib/lsb/remove_initd
===> From spec comment its ok

As comment in SPEC said "# LSB uses /usr/lib rather than /usr/lib64 even for
64bit OS"

you should revert your changes
437c436
< /lib/lsb
---
> /%{_lib}/lsb
otherwise there will be problem on 64bit machine as those files will be
installed in /usr/lib64

cp command should be used like "cp -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.