[Bug 457277] Review Request: pentaho-reporting-flow-engine - Reporting Engine

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457277


Colin Walters <walters at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |walters at redhat.com
    Customer Facing|                            |---




--- Comment #1 from Colin Walters <walters at redhat.com>  2008-08-06 10:05:09 EDT ---
Took a brief look; need to do the build deps first though.

[+] source files match upstream
[+] package meets naming and versioning guidelines.
[+] specfile is properly named, is cleanly written and uses macros consistently
[+] dist tag is present.
[+] build root is correct.
 (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the
recommended value, but not the only one)
[+] license field matches the actual license.
[+] license is open source-compatible.
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper
[+] %clean is present.

-- TO BE REVIEWED

[?] package builds in koji
[?] package installs properly
[?] rpmlint is silent.
please fix.
[?] owns the directories it creates.
[?] doesn't own any directories it shouldn't.
[?] no duplicates in %files.
[?] file permissions are appropriate.
[?] code, not content.
[?] documentation is small, so no -docs subpackage is necessary.
[?] %docs are not necessary for the proper functioning of the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.