[Bug 457767] Review Request: xorg-x11-drv-mach64 - mach64 driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457767





--- Comment #3 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-08-06 13:35:03 EDT ---
APPROVED

Build on koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=762691

rpmlint -i xorg-x11-drv-mach64-6.8.0-1.fc9.src.rpm 
xorg-x11-drv-mach64.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab:
line 3)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance.  Use either spaces or tabs for indentation, not both.

Required:
[x] Name
[x] License
[x] Spec file is in American Eng and legible
[x] Build successfully
[x] BuildRequires 
[x] Duplicate files - nil
[NA] locale
[x] permissions -- okay
[x]  source link correct
[x] packaging guidlines
[x] removing .la 
[x] Buildroot correct
[x] owns every directory it creates
[x] file encoding - checked
[x] package has no dependency on files in %doc
[NA] GUI
[x] No dependencies outside FHS guidelines
[x] md5sum
Source from site: 6081b8fa50c689d51f85c2fbaf93867e
Source from srpm: 6081b8fa50c689d51f85c2fbaf93867e

Optional suggestions:
a. You may like to add some more info to description 
b. clean #{_mandir}/man4/mach64.4*
c. BuildRequires: automake autoconf libtool pkgconfig may be removed

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.