[Bug 453569] Review Request: libmirage - library to provide access to different image formats

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 7 04:55:56 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453569





--- Comment #4 from Debarshi Ray <debarshi.ray at gmail.com>  2008-08-07 00:55:55 EDT ---
(In reply to comment #3)

Please provide URLs to your new Spec/SRPM pair, bump their Release field and
update the %changelog, when you make such a series of changes. That helps in
tracking the changes and progress made during the course of the review.

> + The versioned dependencies on pkgconfig, flex and glib2-devel are not
>  - fixed

The -devel subpackage still has 'Requires: pkgconfig >= 1:0.14'. It should be
'Requires: pkgconfig'.

> + The gzipped tarball is no longer available at the given Source location.
> - a new version has been released during this package review, should I update to it?

Even then the bzipped tarball of 1.0.0 is still available, while the gzipped
counterpart is not. That is enough reason to fix the Source0.

Whether you want to update to a new upstream release is a different matter and
is your decision (I think you should).

Also, the 'BuildRequires: pkgconfig' is not needed and should be removed,
because those build dependencies which provide *.pc files should themselves
bring it in.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list