[Bug 454914] Review Request: nxt_python - a package for controlling a LEGO NXT robot using python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454914





--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-07 10:15:35 EDT ---
Well, for 0.7-2:

* SourceURL
  - Please use %name, %version macros. With using these macros
    perhaps you won't have to modify SourceURL when the version is
    upgraded.

* %PATCH0
  - I guess there is no needed to rename "COPYING" to "LICENSE".
    Please use COPYING file as it is.

* Requires
  - Please check if all needed rpms are correctly added to Requires.
    At least "pygtk2" seems needed for Requires as %_bindir/nxt_python
    contains:
-----------------------------------------------------------
    16  import cStringIO
    17  import gtk
    18  import os.path
-----------------------------------------------------------
    ! Note
      I usually check python module related Requires like below:
-----------------------------------------------------------
$ grep -h 'import ' `rpm -ql nxt_python | grep -v /usr/share/doc` | sort | uniq
-----------------------------------------------------------

* Udev rule config file
  - It seems that usually udev rule config files are not marked as
    (noreplace) (even if rpmlint warns about it)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.