[Bug 448025] Review Request: player - Cross-platform robot device interface and server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448025





--- Comment #19 from Jef Spaleta <jspaleta at gmail.com>  2008-08-07 15:55:39 EDT ---
Formal Review Summary:

Summary:
Only one solid blocker
License text is incorrect.
License: GPLv2+ and LGPLv2+
Reading the source comments they use the "or later version" clause hence the
"+"

The rpmlint errors concerning the zero-length files in the docs subpackage need
to be discussed however before you open up the F9 branch.  I'm marking this as
approved for rawhide as long as you correct the license text.

Full Review:
naming: good
spec-naming: good
license: wrong should be GPLv2+ and LGPLv2+
md5sum matches upstream url
74d221bebd7f68a8ef258aadf0ac185b  included player-2.1.1.tar.bz2
74d221bebd7f68a8ef258aadf0ac185b 
http://mesh.dl.sourceforge.net/sourceforge/playerstage/player-2.1.1.tar.bz2
passes development scratch build on koji
builds locally via mock for rawhide and f9
no locale support needed
ldconfig called post and postun
not relocatable
no dupes in files
macro usage fine
permissible code/content
docs package looks good
static package looks good
devel package looks good, requires pkgconfig as it should
docs section in main package looks good
no .la files installed
install section looks good
desktop files look good
directory ownership looks good

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.