[Bug 453520] Review Request: libUnihan - C library for Unihan character database in 5NF
bugzilla at redhat.com
bugzilla at redhat.com
Fri Aug 8 08:14:29 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453520
--- Comment #10 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2008-08-08 04:14:27 EDT ---
Now for 0.4.1-0:
* Source tarball
- in the srpm does not coincide with what I downloaded from the written
URL?
----------------------------------------------------------
70713 2008-08-08 11:28 libUnihan-0.4.1-0.fc9/libUnihan-0.4.1-Source.tar.gz
71729 2008-08-08 16:02 libUnihan-0.4.1-Source.tar.gz
----------------------------------------------------------
* Requires
** For main package
- Now "Requires: glib2 sqlite" can (and should) be dropped as these
libraries' dependency are automatically checked by rpmbuild itself.
** For -devel subpackage:
- For example, %_includedir/%name/Unihan_enum.h contains:
----------------------------------------------------------
31 #ifndef UNIHAN_ENUM_H_
32 #define UNIHAN_ENUM_H_
33 #include <glib.h>
34 #include <sqlite3.h>
----------------------------------------------------------
This means libUnihan-devel should have "Requires: glib2-devel,
sqlite-devel"
Please also check for other header files.
* cflags
- Fedora specific compilation flags are not correctly honored yet:
http://koji.fedoraproject.org/koji/taskinfo?taskID=765959
I am not a expert of cmake, however as far as I looked Makefiles,
-----------------------------------------------------------
make VERBOSE=1 C_DEFINES="$RPM_OPT_FLAGS" %{?_smp_mflags}
-----------------------------------------------------------
seems to work for this issue
* Removing document files at %install
-----------------------------------------------------------
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/AUTHORS
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/NEWS
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/ChangeLog
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/README
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/COPYING
rm $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/COPYING.LESSER
-----------------------------------------------------------
- Does this mean that you want to remove these files and
_leave_ some other files which are installed under
$RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/ ?
Actually build.log says that many html files and others are installed under
$RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/ like:
-----------------------------------------------------------
348 -- Installing:
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1/html/tabs.css
349 -- Installing:
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1/html/doxygen.css
350 -- Installing:
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1/html/index.html
351 -- Installing:
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1/html/str__functions_8h-sou
rce.html
-----------------------------------------------------------
However these files are removed anyway because you write
-----------------------------------------------------------
%doc AUTHORS NEWS ChangeLog README COPYING COPYING.LESSER
-----------------------------------------------------------
With this %doc usage (i.e. the case in which %doc list is not given
by full path), %doc first removes all files under
$RPM_BUILD_ROOT%{_docdir}/%{name}-%{version} and then (re-)installs
files listed in %doc like:
-----------------------------------------------------------
403 Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.t2hcK9
404 + umask 022
405 + cd /builddir/build/BUILD
406 + cd libUnihan-0.4.1-Source
407 +
DOCDIR=/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1
408 + export DOCDIR
409 + rm -rf
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1
410 + /bin/mkdir -p
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share/doc/libUnihan-0.4.1
411 + cp -pr AUTHORS NEWS ChangeLog README COPYING COPYING.LESSER
/builddir/rpmbuild/BUILDROOT/libUnihan-0.4.1-0.fc10.i386/usr/share
/doc/libUnihan-0.4.1
412 + exit 0
-----------------------------------------------------------
So:
- If you want to once clean up all installed files under
$RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/ and use
"%doc AUTHORS NEWS" method, simply use
-----------------------------------------------------------
rm -rf $RPM_BUILD_ROOT%{_docdir}/%{name}-%{version}/
-----------------------------------------------------------
in %install.
- Or you can leave the installed document files as it is and use:
-----------------------------------------------------------
%files
%defattr(-,root,root,-)
%dir %_docdir/%name-%version
%_docdir/%name-%version/AUTHORS
%_docdir/%name-%version/NEWS
....
....
%files doc
%defattr(-,root,root,-)
%_docdir/%name-%version/html/
-----------------------------------------------------------
here all document files are installed %_docdir/%name-%version, while
currently 3 directories are used to install document files.
Note that all files under %_docdir are marked as %doc, so when
writing
-----------------------------------------------------------
%files
%_docdir/%name-%version/AUTHORS
-----------------------------------------------------------
%doc attribute is not needed.
! Duplicate/unneeded files
- I don't think that "%doc AUTHORS NEWS ChangeLog README" is needed
for -devel subpackage because -devel subpackage always "Requires"
main package (but this is not a blocker).
! Here again see the usage of "%_docdir/%name-%version/AUTHORS" above.
- By the way why is the file GPL (not LGPL) "COPYING" file needed?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list