[Bug 457116] Review Request: crcimg - Construct .crc files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457116


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |opensource at till.name
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2008-08-08 06:19:03 EDT ---
- spec file naming: ok
- buildroot: ok
- summary/description: ok
- license: ok (GPLv2)
  - tag ok
  - matches license header in: crc32.c and crcimg.c
  - license included in %doc: COPYING
- directory ownage: ok
- not a library: ok
- not much documentation: ok
- rm in %clean: ok
- rm in %install: ok
- %defattr in %files: ok
- rpmlint: ok (silent)
- source file matches:
8e8cec7e15dcd3e3b5e35503d74ec636  crcimg-1.1.tar.bz2
8e8cec7e15dcd3e3b5e35503d74ec636  crcimg-1.1-1.fc9/crcimg-1.1.tar.bz2
- source url works: ok
- builds in koji: ok
http://koji.fedoraproject.org/koji/taskinfo?taskID=766134


NOT OK:
- optflags are not honoured:
gcc  -O -Wall -c -o crc32.o crc32.c
gcc  -O -Wall -c -o crcimg.o crcimg.c
gcc   -o crcimg crc32.o crcimg.o

You need to add:
CFLAGS="$RPM_OPT_FLAGS" LDFLAGS="$RPM_OPT_FLAGS" to the make command in %build

For reference:
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

Please fix the optflags issue and I will approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.