[Bug 457325] Review Request: eboard - Chess board interface for ICS

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457325





--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2008-08-08 12:14:22 EDT ---
Thanks for the package marek.

Compiles fine in mock.
Have tested basic functionality.
Using proper make flags (see 2. for compiler flags)
The file list is (mostly, see 0.) sane.
Provides are sane (see 3. for a note on requires).
The SPEC file seems pretty straightforward, legible and very sane.

0.) RPMLint:

eboard.i386: W: devel-file-in-non-devel-package /usr/bin/eboard-config
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.

Actually this is a false positive. eboard-config is not a pkg-config script.
You may still consider if it's appropriate to include it in the pacakge, though
creating a subpackage just for it is definitely not reasonable.

1.) Please do not use %configure

Your ./configure is not autoconf. It doesn't understand the flags you pass to
it.

2.) Proper compiler flags are not used

Please ensure that you pass %optflags to the C++ compiler.
This is closely related to 1.)

3.) Useless requires:

Requires: gtk2
Requires: pango
Requires: cairo
Requires: libpng >= 1.2

These are pulled in by the library dependencies generated by autoreq script. No
need to duplicate those.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.