[Bug 457247] Review Request: sugar-terminal -- Terminal activity for sugar

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457247





--- Comment #1 from Robin Norwood <rnorwood at redhat.com>  2008-08-08 12:30:14 EDT ---
- rpmlint is very noisy:
sugar-terminal.src: W: non-standard-group Sugar/Activities

* Sugar/Activities should probably be added to the standard groups list.
* Filed https://bugzilla.redhat.com/show_bug.cgi?id=458460 to get this done.

sugar-terminal.noarch: E: non-executable-script
/usr/share/sugar/activities/Terminal.activity/setup.py 0644

* Probably just patch out the shebang line or make it non-executable
  since this shouldn't be needed at runtime.

sugar-terminal.noarch: W: file-not-in-%lang
/usr/share/sugar/activities/Terminal.activity/locale/af/LC_MESSAGES/org.laptop.Terminal.mo
(...lots more...)

* Ongoing discussion as to what to do about this on fedora-olpc-list.
  No point in blocking the review, we'll just fix it when the proper
  course of action is decided.


- Package naming is fine
- License is fine
- Source matches upstream (git checkout of a tag)
- Spec file is fine
- File list is fine (except for translations)


APPROVED (Once you fix the rpmlint error)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.