[Bug 458379] Review Request: wondershaper - Simple network shaper

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458379


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name




--- Comment #4 from Till Maas <opensource at till.name>  2008-08-08 13:50:47 EDT ---
The package is missing a:
BuildArch:      noarch

[NOT OK] rpmlint output:
wondershaper.i386: W: incoherent-version-in-changelog 1.1a-2 1.1-0.1.a.f8
This is obvious imho

wondershaper.i386: E: no-binary
I guess it is because the package is not noarch

[OK] Spec in %{name}.spec format
[OK] license: GPL+
[NOT OK] license matches shortname in License:
Imho it should be GPL+, I cannot see a statement that says it is v2 or later
For reference: https://fedoraproject.org/wiki/Licensing
Upstream says:
| Licensed under the GPL

[OK] license in tarball and included in %doc:
COPYING

[OK] package is code or permissive content:
{OK} patches sent to upstream and commented
[OK] Source0 is a working URL
<OK> SourceX / PatchY prefixed with %{name}
[OK] Source0 matches Upstream:
bbc5a3a4485ab286e337ce8550e7b990  wondershaper-1.1a.tar.gz

[OK] Package builds on all platforms: it's noarch
[OK] BuildRequires are complete: no build
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin
[OK] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT
[OK] %build starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT

[OK] Consistent macro usage

[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

{OK} PreReq not used
{OK} no duplication of system libraries

{NOT OK} Timestamps preserved with cp and install
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
install in %install should have -p added

{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} nothing installed in /srv
{OK} Changelog in allowed format


Fix changelog, architecture and install. Use GPL+ as License or show me why it
is GPLv2+. Then I will approve this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.