[Bug 457142] Review Request: olpc-netutils - OLPC network utilities

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457142


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |opensource at till.name
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name




--- Comment #1 from Till Maas <opensource at till.name>  2008-08-08 16:31:26 EDT ---
[OK] rpmlint output: silent
[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv2+
GPLv2+ license headers in all files:
olpc-connections  olpc-log  olpc-mesh  olpc-mpp  olpc-netstatus  olpc-xos 
sugar-telepathies  sugar-xos
[OK] license matches shortname in License-Tag
[OK] license in tarball and included in %doc: COPYING

[OK] package is code or permissive content:

[OK] Source0 is a working URL
[OK] Source0 matches Upstream:
eb66bdf93e1eed8ae822a584abbc9082  olpc-netutils-0.4.tar.bz2

[OK] Package builds on all platforms: noarch
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 
 28 Requires:       /sbin/modprobe
 29 Requires:       /bin/awk
 30 Requires:       /bin/grep


[OK] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[OK] Consistent macro usage

[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)

{OK} well known BuildRoot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
{OK} PreReq not used
{OK} no duplication of system libraries
{OK} no rpath
{NOT OK} Timestamps preserved with cp and install
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps

In Makefile.build install is used without -p for files (line 15). Please
create a patch that adds -p and submit it upstream.

{OK} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{NOT OK} Changelog in allowed format
Afaik, the disttag (.fc9) does not belong in the Changelog
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

{OK} does not use Scriptlets
<OK> Architecture independent packages have: BuildArch: noarch

In conclusion:
- Please add -p to the install in the Makefile as a patch, submit it upstream
and
  mention it in the spec:
install -p -D $< $@
- You should not use the disttag in the changelog

Once the install issue is resolved, I will approve this package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.