[Bug 359911] Review Request: drupal-views - Provides a method for site designers to control content presentation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=359911


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |opensource at till.name
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name




--- Comment #17 from Till Maas <opensource at till.name>  2008-08-08 18:03:47 EDT ---
[OK] rpmlint output: silent under normal conditions
[OK] Spec in %{name}.spec format

[OK] license allowed: GPLv2
[OK] license matches shortname in License: tag
LICENSE.txt indicates GPLv2
[OK] license in tarball and included in %doc:

[OK] package is code or permissive content:
[OK] Source0 is a working URL
[OK] Source0 matches Upstream:
7c69feceffdef7e12ca42a479335f2bc  views-6.x-2.0-beta4.tar.gz

[OK] Package builds on all platforms: noarch
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 

[OK] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[NOT OK] no duplicates in %files
The following files are also copied in /usr/share/drupal/modules/views
CHANGELOG.txt LICENSE.txt README.txt drupal-views-fedora-README.txt

[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[OK] Consistent macro usage

[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)

{Ok} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

{Ok} PreReq not used

{Ok} no duplication of system libraries

{OK} no rpath

{NOT OK} Timestamps preserved with cp and install
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
The drupal-views-fedora-README.txt file is copied without preserving the
timestamp, install -p -m 0644 would be probably the best option

{OK} Requires(pre,post) style notation not used

{Ok} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)

{Ok} no Conflicts

{Ok} nothing installed in /srv

{Ok} Changelog in allowed format
https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

{OK} does not use Scriptlets

<Ok> Architecture independent packages have: BuildArch: noarch

{NOT OK} Follows Naming Guidelines
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages
The Release is missing and additional integer, it should be:

0.1.beta4%{?dist}
  ^- this is missing

The second number needs to be bumped every time you change something, until it
is properly released.

Additional:
The Copying SOURCE1 should go into %prep, because it is not a build step. You
can leave the %build section empty.


In conclusion:
- The duplicate .txt files should not be copied
- The timestamp of SOURCE1 should be preserved
- The release should be created according to the Naming Guidelines
Iirc, these issues are present in your other drupal review requests.


Btw. I also see the 02755 permissions warnings, but I know why they are there!
;-) The BUILD directory of by rpmbuild user has this permissions and therefore
every directory that is created there, too. You could run a recursive chmod on
everything after copying it, to avoid this.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.