Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=225745
Till Maas <opensource at till.name> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |opensource at till.name
AssignedTo|nobody at fedoraproject.org |opensource at till.name
--- Comment #7 from Till Maas <opensource at till.name> 2008-08-08 18:43:48 EDT ---
[NOT OK] rpmlint output:
fedora-logos.noarch: W: invalid-license Not licensed. See COPYING file for
trademark permission.
exception
fedora-logos.noarch: W: no-url-tag
I guess there this should maybe point to
http://fedoraproject.org/wiki/Artwork
or
http://fedoraproject.org/wiki/Logo
fedora-logos.noarch: E: only-non-binary-in-usr-lib
fedora-logos.noarch: E: invalid-desktopfile
/usr/share/applications/screensavers/system.desktop
need to investigate
fedora-logos.src:20: W: unversioned-explicit-obsoletes redhat-logos
probably ok
fedora-logos.src:166: E: hardcoded-library-path in
/usr/lib/anaconda-runtime/boot/*png
fedora-logos.src:167: E: hardcoded-library-path in
/usr/lib/anaconda-runtime/*.sh
fedora-logos.src:168: E: hardcoded-library-path in
/usr/lib/anaconda-runtime/*.jpg
At least %{_prefix} for /usr needs to be used.
fedora-logos.src:557: W: macro-in-%changelog defattr
* Mon Jun 19 2000...
- Add %defattr
There needs to be an extra percent sign:
- Add %%defattr
fedora-logos.src: W: invalid-license Not licensed. See COPYING file for
trademark permission.
fedora-logos.src: W: no-url-tag
see above
[OK] Spec in %{name}.spec format
[EXCEPTION] license allowed:
This is a special package afaics.
[OK] license in tarball and included in %doc:
COPYING
[OK] package is code or permissive content:
[EXCEPTION] Source0 is a working URL
Afaics CVS is the upstream location for the Sources
<NOT OK> SourceX / PatchY prefixed with %{name}
Source1: background.png
Imho this is to generic, fedora-logos-background.png would be better.
[EXCEPTION] Source0 matches Upstream:
[OK] Package builds on all platforms: noarch
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin
[OK] Prefix: /usr not used (not relocatable)
https://fedoraproject.org/wiki/Packaging/Guidelines#Relocatable_packages
[NOT OK] Owns all created directories:
e.g.: /usr/share/kde4/apps/ksplash/Themes
not sure, whether this is ok. Maybe you should multiown these directories,
too.
[NOT OK] no duplicates in %files
155 %{_datadir}/icons/hicolor/*/apps/*
156 %{_datadir}/icons/Bluecurve/*/apps/*
162 # we multi-own these directories, so as not to require the packages that
163 # provide them, thereby dragging in excess dependencies.
164 %{_datadir}/icons/Bluecurve
165 %{_datadir}/icons/hicolor
Either drop lines 155 and 156 or add a %dir before lines 164 and 165.
[OK] %defattr(-,root,root,-) is in every %files section
[EXCEPTION] Does not own files or dirs from other packages
see comment in spec
[OK] included filenames are in UTF-8
[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT
[NOT OK] Consistent macro usage
/usr/lib/anaconda-runtime/boot/*png
/usr/lib/anaconda-runtime/*.sh
/usr/lib/anaconda-runtime/*.jpg
Use %{_prefix} instead of /usr
[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime
{OK} no pre-built binaries (.a, .so*, executable)
{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
{OK} PreReq not used
{OK} no duplication of system libraries
{OK} no rpath
{OK} Timestamps preserved with cp and install
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} nothing installed in /srv
{OK} Changelog in allowed format
<OK> Architecture independent packages have: BuildArch: noarch
{OK} Follows Naming Guidelines
Will check later:
{} Conflicts
https://fedoraproject.org/wiki/Packaging/Conflicts
{} Scriptlets
complete rpmlint output (desktop file)
Btw:
infinity-grub.xpm.gz is both in cvs and sources file
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.