[Bug 458457] Review Request: grc - GUI for GNURadio

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458457





--- Comment #6 from Lubomir Rintel <lkundrak at v3.sk>  2008-08-08 19:05:30 EDT ---
> > 1.) Please do not create scripts inline in SPEC
> > 
> > That is utterly ugly. You should be ashamed.
> 
> Any guideline against this? I like it.

Yup:
"- MUST: The spec file for the package MUST be legible."

> 
> > 2.) Fix your runtime dependencies.
> > 
> > You seem to import at least wx, gtk, pango, etc. We do not have autoreqs for
> > python. Please add the necessary Requires.
> > 
> > The upstream web [1] recommends the following, which you may want to base your
> > decision upon:
> > 
> >     * wx-python
> >     * numpy
> >     * gnuradio with gr-wxgui
> >     * python-gtk2(>=2.6)
> >     * python-xml and/or pyxml 
> > 
> > [1] http://gnuradio.org/trac/wiki/GNURadioCompanion
> 
> All those are fetched with GNURadio itself, this should be fine.

I do not think so. Fedora 9:

[lkundrak at jesus ~]$ grc

Missing critical module: "xml.dom.ext"

Exiting!

[lkundrak at jesus ~]$ 

> > 3.) License tag does not seem correct.
> > 
> > At least you include some CC blurb in %doc. Are you sure you don't ship any
> > Creative Commons stuff?
> 
> Only the icon is under CC, however it's shipped with the package under GPLv2+,
> should I mention it anyway?

I do not know what does the CC license of the icon say. By including the icon
license in License tag can not do any harm, well, I guess... when in doubt
please ask on legal m-l.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.