[Bug 458543] Review Request: eg - a wrapper for Git

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458543


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |opensource at till.name




--- Comment #2 from Till Maas <opensource at till.name>  2008-08-10 10:24:34 EDT ---
(In reply to comment #1)
> > eg.spec:61: E: use-of-RPM_SOURCE_DIR
> > You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
> > a directory for building, use $RPM_BUILD_ROOT instead.
> 
> It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be
> easier to install %{SOURCE0} directly?

Imho it the source should be copied to the build-dir in %setup, therefore
instead of
cp $RPM_SOURCE_DIR/%{name} $RPM_BUILD_DIR/%{name}-%{version}
this would be better in %prep:

cp -p %SOURCE0 .

I did not test it, but imho it should work. Also note the "-p" to preserve the
timestamp.

When %SOURCE0 would be directly installed in %install, then it make much more
work to create a patch, e.g. I normally run make prep, create the patch and use
"make patch SUFFIX=foo" in Fedora CVS.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.