[Bug 454687] Review Request: perl-Mail-ClamAV - Perl extension for the clamav virus scanner
bugzilla at redhat.com
bugzilla at redhat.com
Sun Aug 10 20:18:52 UTC 2008
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454687
Jason Tibbitts <tibbs at math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |tibbs at math.uh.edu
Summary|Review Request: |Review Request:
|perl-Mail-ClamAV - Perl |perl-Mail-ClamAV - Perl
|extension for the clamav |extension for the clamav
|virus scanner |virus scanner
--- Comment #1 from Jason Tibbitts <tibbs at math.uh.edu> 2008-08-10 16:18:51 EDT ---
This is standard Perl module, but a couple of things bother me.
If you visit the upstream URL, you can't see version 0.22, just 0.13. If you
search for ClamAV on CPAN you'll see a link to 0.22, but clicking there gets
you a page with a big red "UNAUTHORIZED" warning. What's that about?
When running the tests, I see the following:
(in cleanup) panic: free from wrong pool.
which is kind of troubling.
I see no problems with the packaging, but I'm reluctant to approve this without
some discussion of those two issues.
* source files match upstream:
1927671296cd398a1b0ce3102683ed23e78648fc9dd643a8fab92d18e33b010b
Mail-ClamAV-0.22.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
ClamAV.so()(64bit)
perl(Mail::ClamAV) = 0.22
perl(Mail::ClamAV::Status)
perl-Mail-ClamAV = 0.22-1.fc10
perl-Mail-ClamAV(x86-64) = 0.22-1.fc10
=
libclamav.so.4()(64bit)
libclamav.so.4(CLAMAV_PUBLIC)(64bit)
perl >= 0:5.006001
perl(:MODULE_COMPAT_5.10.0)
perl(Carp)
perl(Class::Struct)
perl(Exporter)
perl(IO::Handle)
perl(Inline)
perl(Inline) >= 0.44
perl(strict)
perl(warnings)
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=10, 2 wallclock secs ( 0.01 usr 0.00 sys + 1.58 cusr 0.12
csys = 1.71 CPU)
(discounting the weird panic at the end)
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list