[Bug 444235] Review Request: djview4 - DjVu viewer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=444235


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #3 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-10 18:30:09 EDT ---
Builds fine and rpmlint is silent.

I note that the compiler is called properly everywhere except when compiling
nsdejavu.c.  However, the plugin isn't actually installed by this package, so
I'm not going to worry about it.  However, if in the future you decide to turn
on the plugin, you'll have several things to look at.  (The licensing is
different, for one thing.)

Your scriptlets seem to be missing the
  if [ -x %{_bindir}/gtk-update-icon-cache ] ; then
    %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
  fi
part.  See
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache



* source files match upstream:
   a783c3700f32d31b0a2a8662d5e2abcd1b4ab3cc129543daaa8af9211135e911  
   djview4-4.3.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
? compiler flags are appropriate.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   djview4 = 4.3-1.fc10
   djview4(x86-64) = 4.3-1.fc10
  =
   /bin/sh
   libQtCore.so.4()(64bit)
   libQtGui.so.4()(64bit)
   libQtNetwork.so.4()(64bit)
   libX11.so.6()(64bit)
   libXext.so.6()(64bit)
   libdjvulibre.so.15()(64bit)
   libgcc_s.so.1()(64bit)
   libgcc_s.so.1(GCC_3.0)(64bit)
   libjpeg.so.62()(64bit)
   libstdc++.so.6()(64bit)
   libstdc++.so.6(CXXABI_1.3)(64bit)
   libstdc++.so.6(GLIBCXX_3.4)(64bit)

* %check is not present; no test suite upstream.  I have not tested this 
   package.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
X scriptlets missing icon cache update.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
* desktop files valid and installed properly.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.