[Bug 458610] Review Request: php-pear-MDB2-Driver-pgsql - PostgreSQL MDB2 driver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458610


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu




--- Comment #2 from Jason Tibbitts <tibbs at math.uh.edu>  2008-08-10 18:52:15 EDT ---
Indeed, rpmlint complains about the two things you've pointed out; I agree that
both complaints can be ignored.

The only thing I could suggest you add is some statement of why the file has to
be patched after installation instead if in %prep as usual.  (I understand why
but it might not be obvious to whoever might glance at the spec in the future.)

* source files match upstream:
   7a051e90c63897701a93c9d3b02d79e6c696240c552694cf34cbc7eab6284691  
   MDB2_Driver_pgsql-1.4.1.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream (it's in each of the PHP files).
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint has acceptable complaints.
* final provides and requires are sane:
   php-pear(MDB2_Driver_pgsql) = 1.4.1
   php-pear-MDB2-Driver-pgsql = 1.4.1-1.fc10
  =
   /bin/sh
   /usr/bin/pear
   php-pear(MDB2) >= 2.4.1
   php-pear(PEAR)

* %check is not present; there's a test suite, but it would require a running 
   postgres instance and pear tests aren't runnable at build time in any case.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear module registration).
* code, not content.
* no documentation to worry about.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.