[Bug 454025] Review Request: libixp - stand-alone client/server 9P library including ixpc client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454025





--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-11 09:37:03 EDT ---
Well, for 0.4-2:

* Summary/%description
  - "Libixp is a " part is redundant for Summary
  - The Summary for -devel subpackage is not proper.
    Usually this is "Development files for foo".
  - Main package and -devel subpackage have the same %description.
    However the purpose of the two packages are different and
    this is not proper. Please modify the %description.

    You can refer to the %description in the skeleton spec
    file created by "$ rpmdev-newspec -t lib foo".

* 64 bit arch issue
  - Well, actually the fix is not easy, as this package uses somewhat
    unique makefiles which don't seem to be based on recent Makefiles.
    As a workaround, I propose:
-------------------------------------------------------
%setup -q
# Make build.log more verbose
find . -type f | xargs grep -l '.SILENT' | xargs sed -i.silent -e
's|\.SILENT||'

# Umm... fixing 64 bits archtecture directory issue cannot be easy done
# by applying a patch, using sed...

grep -rl '/lib' . | xargs sed -i.lib \
 -e 's|/lib\([ /]\)|/%{_lib}\1|' \
 -e 's|/lib$|/%{_lib}|'

-------------------------------------------------------

   ! The above %setup also contains a fix to make build.log more verbose
   !!! Please recheck what I do by the script above.

* Cflags
  - As I wrote in the comment 1, Fedora specific compilation flags are
    not correctly honored:
    https://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags
    For this package the following works (note: the following method is
    this package specific)
--------------------------------------------------------
%build
make %{?_smp_mflags} \
 CC="%{__cc} -c %optflags"
--------------------------------------------------------

* %files entry v.s. debuginfo rpm issue
  - Currently (after cflags issue is fixed) rpmlint complains:
--------------------------------------------------------
libixp-devel.i386: W: hidden-file-or-dir /usr/lib/debug/.build-id
libixp-devel.i386: W: hidden-file-or-dir /usr/lib/debug/.build-id
libixp-devel.i386: W: dangling-relative-symlink
/usr/lib/debug/.build-id/52/fcd345977adcc0861159407db91f2bc489d3e2
../../../../bin/ixpc
libixp-devel.i386: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/ixpc.debug
libixp-devel.i386: E: statically-linked-binary
/usr/lib/debug/usr/bin/ixpc.debug
--------------------------------------------------------

   debuginfo rpms installs files under %_libdir/debug so writing %files
   entry like:
--------------------------------------------------------
%files devel
%defattr(-,root,root,-)
%{_libdir}/*
--------------------------------------------------------
   is wrong because %_libdir/* contains %_libdir/debug, while files under
   this directory must be owned by -debuginfo rpm and not -devel rpm.
   Please don't use "%{_libdir}/*" and replace this with
   "%{_libdir}/libixp*.a", for example.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.