[Bug 450621] Review Request: itaka - On-demand screen capture server

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=450621


Nicolas Chauvet (kwizart) <kwizart at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kwizart at gmail.com




--- Comment #3 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-08-11 19:06:41 EDT ---
1/ There is no need for Requires: python >= 2.3 as package already have 
Requires: python(abi) = 2.5

2/ gzip -9 -c share/itaka.1 > share/itaka.1.gz at install step.
This is usually unneeded, rpm takes care of compression at
/usr/lib/rpm/redhat/brp-compress step.
It seems that the compression option can be different. (it will use gzip -9 -n)
It shouldn't have any problem unless we choose a different compression method
for all man pages later..

*/timestamps and md5sum are the same from source files and packages
25c0919219c7e0479ab3f0534eadf25e  itaka-0.2.1.tar.bz2
-rw-rw-r-- 1 builder builder 311287 jui 19  2007 itaka-0.2.1.tar.bz2
good

3/ /usr/share/itaka/ is not owned by the package. You need to add:
%dir %{_datadir}/%{name}


4/ License is GPLv2+, but COPYRIGHT also mention icons to be Creative Commons
Attribution-ShareAlike (CC-BY-SA) 
according to
http://fedoraproject.org/wiki/Licensing#License_of_Fedora_SPEC_Files
It is FSF compatible but need to be mentioned:
License:        GPLv2+ and CC-BY-SA

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.