[Bug 458785] Review Request: libev - High-performance event loop/event model with lots of features

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458785





--- Comment #3 from Nicolas Chauvet (kwizart) <kwizart at gmail.com>  2008-08-12 10:08:52 EDT ---
+ License is GPLv2+ or BSD and fit the package Licensed field
+ The source tarball from the development site and the src.rpm are the same
 6dddea9189345f0c8c36c4eb8ecce441  libev-3.43.tar.gz
+ The spec file is readable
+ Package build in mock (local: F-8 x86_64) and Rawhide for all arches: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=773760
+ Package use our CFLAGS


1/ Please use INSTALL="install -p" at make install step to avoid timstramps
changes while installing headers.

2/ Package bundled a static library by default.
If really needed, it would be better to move this library to a -devel-static
sub-package. If not, just add --disable-static at the configure step.

3/ There is a name clash with event.h from libevent. This suggest that the
headers should be removed from the default include directory (ie  /usr/include)
to be provided in a subdirectory by default (ie /usr/include/libev ). So the
name clash doesn't occur anymore.
This change would be required for libevent eventually.

4/ Package lack to provide support of pkg-config for libev. It would be fine to
have libev.pc for the dependant packages that will use libev.

+ no .pc file present.
+ no .la files.
+ Requires look sane
+ rpmlint on installed pacakge is quiet
+ package install/uninstall went fine

There is 4 points that can be improved.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.