[Bug 457839] Review Request: rubygem-cobbler - Provides Ruby bindings to interact with a Cobbler server.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457839





--- Comment #1 from Bryan Kearney <bkearney at redhat.com>  2008-08-12 17:07:05 EDT ---
* General

  OK - Package name
 But why a gem?

  XX - License info is accurate

 Specify LGPL based on COPYING File

  OK - License tag is correct and licenses are approved
  OK - License files are installed as %doc
  OK - Specfile name
  XX - Specfile is legible

 Explicitly list the test files, and their permissions. No Loops.

  OK - No prebuilt binaries included
  OK - BuildRoot value (one of the recommended values)
  OK - PreReq not used
  OK - Source md5sum matches upstream
  OK - No hardcoded pathnames
  OK - Package owns all the files it installs
  OK - 'Requires' create needed unowned directories
  XX - Package builds successfully on i386 and x86_64 (mock)

 OUTPUT of "rpmbuild --rebuild rubygem-cobbler-0.0.1-1.fc9.src.rpm "
 Installing rubygem-cobbler-0.0.1-1.fc9.src.rpm
 warning: user mcpierce does not exist - using root
 warning: group mcpierce does not exist - using root
 warning: user mcpierce does not exist - using root
 warning: group mcpierce does not exist - using root
 Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.30412
 + umask 022
 + cd /home/bkearney/rpmbuild/BUILD
 /var/tmp/rpm-tmp.30412: line 23: cd: /home/bkearney/rpmbuild/BUILD: No such
file or directory
 error: Bad exit status from /var/tmp/rpm-tmp.30412 (%prep)


 OUTPUT of "rpmbuild -bb rubygem-cobbler.spec"
 Processing files: rubygem-cobbler-0.0.1-1.fc9
 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/COPYING
 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/NEWS
 warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/README
 warning: File listed twice:
/usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/config/cobbler.yml
 Provides: config(rubygem-cobbler) = 0.0.1-1.fc9 rubygem(cobbler) = 0.0.1
 Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <=
3.0.3-1
 Requires: /usr/bin/ruby config(rubygem-cobbler) = 0.0.1-1.fc9 rubygems
 Checking for unpackaged file(s): /usr/lib/rpm/check-files
/var/tmp/rubygem-cobbler-0.0.1-1.fc9-root-bkearney
 Wrote:
/home/bkearney/rpmbuild/RPMS/noarch/rubygem-cobbler-0.0.1-1.fc9.noarch.rpm
 Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.53996


  OK - BuildRequires sufficient
  OK - File permissions set properly
  OK - Macro usage is consistent
  XX - rpmlint is silent

 rpmlint rubygem-cobbler-0.0.1-1.fc9.src.rpm 
 rubygem-cobbler.src: W: mixed-use-of-spaces-and-tabs (spaces: line 34, tab:
line 8)
 1 packages and 0 specfiles checked; 0 errors, 1 warnings.

 rpmlint rubygem-cobbler-0.0.1-1.fc9.noarch.rpm 
 rubygem-cobbler.noarch: E: file-in-usr-marked-as-conffile
/usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/config/cobbler.yml
 rubygem-cobbler.noarch: W: conffile-without-noreplace-flag
/usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/config/cobbler.yml
 1 packages and 0 specfiles checked; 1 errors, 1 warnings.



* Package a rubygem

  OK - Package is named rubygem-%{gemname}
  OK - Source points to full URL of gem
  OK - Package version identical with gem version
  OK - Package Requires and BuildRequires rubygems
  OK - Package provides rubygem(%{gemname}) = %version
  OK - Package requires gem dependencies correctly
  OK - %prep and %build are empty
  XX - %gemdir defined properly, and gem installed into it

 [bkearney at localhost noarch]$ sudo rpm --install
rubygem-cobbler-0.0.1-1.fc9.noarch.rpm 
  package rubygem-cobbler-0.0.1-1.fc9.noarch is already installed
 [bkearney at localhost noarch]$ irb
 irb(main):001:0> require "cobbler"
 LoadError: no such file to load -- cobbler
  from (irb):1:in `require'
  from (irb):1

  OK - Package owns its directories under %gemdir

** noarch rubygem

  OK - No arch-specific content in %{gemdir}
  OK - Package is noarch

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.