[Bug 454330] Review Request: gresolver - Graphical DNS query tool

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=454330





--- Comment #1 from Dan Horák <dan at danny.cz>  2008-08-13 08:15:00 EDT ---
formal review is here, see the notes below

OK source files match upstream:
     3acb6d294489ac0393d090ba5361dfead47668aa  gresolver-0.0.5.tar.gz
OK package meets naming and versioning guidelines.
BAD specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK build root is correct.
BAD license field matches the actual license.
OK license is open source-compatible. License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
N/A debuginfo package looks complete.
OK rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
BAD doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK is a GUI app, desktop file installed


- maybe you could skip "make build" and generate the file with sed => no need
for BR: perl
- you should use "make install prefix=..." instead of %makeinstall
(https://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used)
- license is "the same as Perl" (see gresolver.pl) => GPL+ or Artistic
- you should split the %{_datadir}/* line into at least
    %{_datadir}/applications/*.desktop and %{_datadir}/%{name} otherwise
    the package will incorrectly own %{_datadir}/applications (and looks like
others dirs are hidden there)
- empty directory %{_datadir}/locale/*/... is created and included in package
(are the translations missing from source package??)
- no need to specify Requires: perl-Gtk2, perl-Gtk2-GladeXML,
perl-Net-IPv6Addr, they are found automagically

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.