[Bug 453772] Review Request: perl-Gtk2-ImageView - Perl bindings to the GtkImageView image viewer widget

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453772





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-13 13:46:09 EDT ---
Created an attachment (id=314227)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=314227)
local rebuild log of 0.04-3 on rawhide i386 machine

For 0.04-3:

* License
  - As far as I checked the whole code, the license tag must be
    "LGPLv3+".

* %SOURCE0
  - Please use %version macro. With this you probably won't have to modify
    %SOURCE9 URL when the version is upgraded.

  - The tarball in your srpm does not coincide with what I could download
    from the URL written as %SOURCE0:
-----------------------------------------------------------------
44080 2008-03-18 04:42 Gtk2-ImageView-0.04.tar.gz
43947 2008-03-15 05:24
perl-Gtk2-ImageView-0.04-3.fc9/Gtk2-ImageView-0.04.tar.gz
-----------------------------------------------------------------

* BuildRequires
  - For perl module related Requires, please specify it by the virtual
    module names the rpms provide, not by using the rpms' name directly.
    https://fedoraproject.org/wiki/Packaging/Perl#Perl_Requires_and_Provides

    * e.g. Usually "BuildRequires: perl-Glib" should be
           "BuildRequires: perl(Glib)" or so.

* %check
  - %check fails on local build (log attached)
    Note that rpmbuild always unset DISPLAY env as:
------------------------------------------------------------------
Executing(%check): /bin/sh -e /home/tasaka1/rpmbuild/INSTROOT/rpm-tmp.54049
+ umask 022
+ cd /home/tasaka1/rpmbuild/BUILD
+ cd Gtk2-ImageView-0.04
+ unset DISPLAY
+ tty -s
+ make test
------------------------------------------------------------------
    For this package this seems to be leading to test failure.

* rpmlint issue

* Documents
  - Usually the file "INSTALL" is for the users who want to rebuild
    the package by themselves and is not needed for rpm users.
  - The file "MANIFEST" should be removed from %doc (actually rpmlint
    warns about this)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.