[Bug 448717] Review Request: gnome-rdp - rdesktop front end

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=448717





--- Comment #12 from Christoph Wickert <fedora at christoph-wickert.de>  2008-08-13 14:48:37 EDT ---
There are still a lot of issues with this package so I don't think that a full
review makes sense at this state.

1) rpmlint /var/lib/mock/fedora-rawhide-i386/result/gnome-rdp-*
gnome-rdp.i386: W: file-not-utf8 /usr/share/doc/gnome-rdp-0.2.2.3/AUTHORS
gnome-rdp.i386: W: file-not-utf8 /usr/share/doc/gnome-rdp-0.2.2.3/ChangeLog
- this is minor and can be fixed with iconv

gnome-rdp.i386: E: description-line-too-long gnome-rdp is a Remote Desktop
Protocol client for the GNOME desktop environment.
- description needs a line wrap after 79 characters

gnome-rdp.i386: E: no-binary
gnome-rdp.i386: E: only-non-binary-in-usr-lib
- because it's mono, save to ignore

gnome-rdp-debuginfo.i386: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 5 errors, 2 warnings.
- why is there no debuginfo? if there really is none you should disable
building the debuginfo package

2) IMO the description could be a little more elaborate, e. g.:
"gnome-rdp is a Remote Desktop Protocol client for the GNOME desktop
environment. It supports RDP, VNC and SSH. Configured sessions can be saved to
the built in list." (Taken from the sf.net website)

3) You are not providing a URL for Source0, see
http://fedoraproject.org/wiki/Packaging/SourceURL

4) You are using ExcludeArch for PPC and PPC64, but you are not providing any
details about the reasons. Please read the corresponding paragraph at 
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines

5) Looks as if you are missing some (Build)Requires:
  checking for vncviewer... vncviewer
  checking for rdesktop... rdesktop
  checking for ssh... ssh
  checking for gnome-terminal... gnome-terminal

6) On F9 build fails with
  configure: error: Package requirements (vte-sharp-0.16 >= 1.9) were not met:
  No package 'vte-sharp-0.16' found
Can you tighten the BuildRequires so that RPM will refuse to install the SRPM
if the requirements are not met?

7) There must be one blank line between every changelog entry. This is
important because the changelogs get parsed automatically by a couple of
scripts.

8) This is not the latest version. 0.2.3 is out since 2008-06-27.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.