[Bug 458288] Review Request: gitosis - git repository hosting application

bugzilla at redhat.com bugzilla at redhat.com
Thu Aug 14 07:09:21 UTC 2008


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458288





--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2008-08-14 03:09:20 EDT ---
Okay.

* Permission
(In reply to comment #2)
> I have a warnings from rpmlint:
> $ rpmlint gitosis-0.2-5.20080730git.fc9.noarch.rpm
> gitosis.noarch: W: non-standard-uid /var/lib/gitosis gitosis
> gitosis.noarch: W: non-standard-gid /var/lib/gitosis gitosis
> gitosis.noarch: E: non-standard-dir-perm /var/lib/gitosis 0750
> 1 packages and 0 specfiles checked; 1 errors, 2 warnings.
> 
> Why? I create gitosis user and homedir by the package with appropriately
> permissions (0750). 

  - If you really want 0750 permission, not 0755, then set explicitly the
permission
    as 0750 (by %attr) and _ignore_ the rpmlint error.

* Macros
------------------------------------------------------------
    64  %dir %attr(0755,gitosis,gitosis) /var/lib/gitosis
------------------------------------------------------------
  - Please change /var to %{_localstatedir}

Please fix or modify these issue when importing this package into Fedora.
Other things are okay.

------------------------------------------------------------------------------------
              This package (gitosis) is APPROVED by mtasaka
------------------------------------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Install the Client Tools (Koji)". Now I am sponsoring you.

If you want to import this package into Fedora 8/9, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the package-review mailing list