[Bug 457839] Review Request: rubygem-cobbler - Provides Ruby bindings to interact with a Cobbler server.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=457839





--- Comment #3 from Darryl L. Pierce <dpierce at redhat.com>  2008-08-14 08:47:48 EDT ---
UPDATED:
Specfile: http://mcpierce.fedorapeople.org/rubygem-cobbler.spec
SRPM: http://mcpierce.fedorapeople.org/rubygem-cobbler-0.0.1-3.fc9.src.rpm
RPM: http://mcpierce.fedorapeople.org/rubygem-cobbler-0.0.1-3.fc9.noarch.rpm

(In reply to comment #1)
> * General
> 
>   OK - Package name
>  But why a gem?

It makes it easier for developers to consume it as a dependency, along the
lines of Maven.

>   XX - License info is accurate
> 
>  Specify LGPL based on COPYING File

Fixed. It is now LGPLv2+, same as Cobbler.

>   XX - Specfile is legible
> 
>  Explicitly list the test files, and their permissions. No Loops.

Done.

>   XX - Package builds successfully on i386 and x86_64 (mock)
> 
>  OUTPUT of "rpmbuild --rebuild rubygem-cobbler-0.0.1-1.fc9.src.rpm "
>  Installing rubygem-cobbler-0.0.1-1.fc9.src.rpm
>  warning: user mcpierce does not exist - using root
>  warning: group mcpierce does not exist - using root
>  warning: user mcpierce does not exist - using root
>  warning: group mcpierce does not exist - using root
>  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.30412
>  + umask 022
>  + cd /home/bkearney/rpmbuild/BUILD
>  /var/tmp/rpm-tmp.30412: line 23: cd: /home/bkearney/rpmbuild/BUILD: No such
> file or directory
>  error: Bad exit status from /var/tmp/rpm-tmp.30412 (%prep)

This error's not due to the RPM.

>   XX - rpmlint is silent
> 
>  rpmlint rubygem-cobbler-0.0.1-1.fc9.src.rpm 
>  rubygem-cobbler.src: W: mixed-use-of-spaces-and-tabs (spaces: line 34, tab:
> line 8)
>  1 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
>  rpmlint rubygem-cobbler-0.0.1-1.fc9.noarch.rpm 
>  rubygem-cobbler.noarch: E: file-in-usr-marked-as-conffile
> /usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/config/cobbler.yml
>  rubygem-cobbler.noarch: W: conffile-without-noreplace-flag
> /usr/lib/ruby/gems/1.8/gems/cobbler-0.0.1/config/cobbler.yml
>  1 packages and 0 specfiles checked; 1 errors, 1 warnings.

Fixed.

>   XX - %gemdir defined properly, and gem installed into it
> 
>  [bkearney at localhost noarch]$ sudo rpm --install
> rubygem-cobbler-0.0.1-1.fc9.noarch.rpm 
>   package rubygem-cobbler-0.0.1-1.fc9.noarch is already installed
>  [bkearney at localhost noarch]$ irb
>  irb(main):001:0> require "cobbler"
>  LoadError: no such file to load -- cobbler
>   from (irb):1:in `require'
>   from (irb):1

Fixed. In the GemSpec, require_path was misconfigured as "." rather than "lib".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.