[Bug 458396] Review Request: denemo - Graphical music notation program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=458396


Ruben Kerkhof <ruben at rubenkerkhof.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ruben at rubenkerkhof.com




--- Comment #1 from Ruben Kerkhof <ruben at rubenkerkhof.com>  2008-08-15 06:41:24 EDT ---
Hi Roy,

A few initial comments:
- are the defines on the top of the spec needed? You can just set the Name,
Version and Release tags and refer to them in the rest of the spec as %{name},
%{version} and %{release}
- You're using RPM_BUILD_ROOT everywhere, except on line 43, there it's
%{buildroot}
- You can use %{_includedir} instead of %{prefix}/include on line 40
- The defattr on line 50 should be %defattr(-,root,root,-)
- Could you pick one of the BuildRoots from
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.