[Bug 456190] Review Request: dosemu - dos emulator

Sat Aug 16 14:26:17 UTC 2008

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=456190

Rakesh Pandit <rakesh.pandit at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rakesh.pandit at gmail.com

--- Comment #6 from Rakesh Pandit <rakesh.pandit at gmail.com>  2008-08-16 10:26:16 EDT ---

rpmlint output:

[rpmbuild at rocky dosemu]$ rpmlint -i dosemu-1.4.0-1868svn.src.rpm 
dosemu.src:14: W: buildprereq-use bison flex
The use of BuildPreReq is deprecated, build dependencies are always required
before a package can be built.  Use plain BuildRequires instead.

dosemu.src:21: W: rpm-buildroot-usage %prep rm -rf $RPM_BUILD_ROOT
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it will
break short circuiting.

dosemu.src:24: E: use-of-RPM_SOURCE_DIR
You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
a directory for building, use $RPM_BUILD_ROOT instead.

dosemu.src:25: W: configure-without-libdir-spec
A configure script is run without specifying the libdir. configure options
must be augmented with something like --libdir=%{_libdir} whenever the script
supports it.

dosemu.src: E: no-cleaning-of-buildroot %install
You should clean $RPM_BUILD_ROOT in the %clean section and just after the
beginning of %install section. Use "rm -Rf $RPM_BUILD_ROOT".

dosemu.src: W: non-standard-group System/Emulators
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games", "Amusements/Graphics", "Applications/Archiving",
-------------

dosemu.src: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

dosemu.src: W: invalid-license GPL
The value of the License tag was not recognized.  Known values are: "Adobe",
------------

dosemu.src: W: no-url-tag
The URL tag is missing.

1 packages and 0 specfiles checked; 3 errors, 6 warnings.

rpmlint after building for i386:
[rpmbuild at rocky i386]$ rp -i dosemu-1.4.0-1868svn.i386.rpm 
dosemu.i386: W: symlink-should-be-relative /etc/dosemu/drives/d
/usr/share/dosemu/drive_z
Absolute symlinks are problematic eg. when working with chroot environments.

dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/dosemu.1.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

dosemu.i386: W: symlink-should-be-relative /etc/dosemu/drives/c
/usr/share/dosemu/drive_z
Absolute symlinks are problematic eg. when working with chroot environments.

dosemu.i386: E: non-standard-dir-perm /usr/share/dosemu 0775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/mkfatimage16.1.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

dosemu.i386: W: file-not-utf8 /usr/share/doc/dosemu/COPYING.DOSEMU
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

dosemu.i386: E: non-standard-dir-perm /usr/share/dosemu/drive_z/doc/exe2bin
0775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

dosemu.i386: E: non-standard-dir-perm /usr/share/dosemu/drive_z 0775
A standard directory should have permission set to 0755. If you get this
message, it means that you have wrong directory permissions in some dirs
included in your package.

dosemu.i386: W: dangling-symlink /usr/share/dosemu/drive_z/tmp /tmp
The symbolic link points nowhere.

dosemu.i386: W: symlink-should-be-relative /usr/share/dosemu/drive_z/tmp /tmp
Absolute symlinks are problematic eg. when working with chroot environments.

dosemu.i386: W: file-not-utf8 /usr/share/man/ru/man1/dosemu.bin.1.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile for example using iconv(1).

dosemu.i386: E: no-changelogname-tag
There is no %changelog tag in your spec file. To insert it, just insert a
'%changelog' in your spec file and rebuild it.

dosemu.i386: W: no-url-tag
The URL tag is missing.

dosemu.i386: W: unstripped-binary-or-object /usr/lib/dosemu/libplugin_term.so
dosemu.i386: W: unstripped-binary-or-object /usr/lib/dosemu/libplugin_X.so
dosemu.i386: W: unstripped-binary-or-object /usr/lib/dosemu/libplugin_sdl.so
dosemu.i386: W: unstripped-binary-or-object /usr/lib/dosemu/libplugin_gpm.so
dosemu.i386: W: unstripped-binary-or-object
/usr/lib/dosemu/libplugin_sndfile.so
dosemu.i386: W: unstripped-binary-or-object /usr/lib/dosemu/libplugin_alsa.so
dosemu.i386: W: dangerous-command-in-%pre mv
1 packages and 0 specfiles checked; 4 errors, 18 warnings.

* SPEC file will look sane if different sections have space between.
* repetitive patterns are reduced with regular exp or loop constructs --
optional
* Changelog present
* URL & source url present.
* Correct License tag
* rpmlint output needs to be clean. removing 'E' are MUST. rpmlint -i shows
necessary diagnosing messages.
* may be you can consult few example specs from other packages.
* And skim Packaging Guideline must items.
* use relative sym links -- move to folder and create 'ln -s <target>
/path/to/<link_name>
* chmod +x /path/to/*so will remove unstripped-binary-or-object warning

Note: Wiki and packageDB are down for the moment but hopefully will be soon up.

waiting for update..

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.